Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1392953003: Add view for MegamorphicCache. Update view for ObjectPool. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add view for MegamorphicCache. Update view for ObjectPool. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8341085f11a6f35a645e6614492d49b01cc6a32b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -50 lines) Patch
M runtime/observatory/lib/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/megamorphiccache_view.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/lib/src/elements/megamorphiccache_view.html View 2 chunks +10 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.dart View 1 chunk +1 line, -21 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +25 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-12 20:40:08 UTC) #2
Cutch
lgtm
5 years, 2 months ago (2015-10-12 20:45:33 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-12 20:57:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8341085f11a6f35a645e6614492d49b01cc6a32b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698