Issue 139293012: Revert 245093 "Flag-flip of app-list-voice-search. Now it's on b..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139293012: Revert 245093 "Flag-flip of app-list-voice-search. Now it's on b..." (Closed)

Created:
6 years, 11 months ago by Jun Mukai

Modified:
6 years, 11 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 245093 "Flag-flip of app-list-voice-search. Now it's on b..." This flag flip accidentally shows the UI in Windows but it should not. > Flag-flip of app-list-voice-search. Now it's on by default. > > BUG=333914 > R=xiyuan@chromium.org > TEST=manually > > Review URL: https://codereview.chromium.org/139293007 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245184

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	trunk/src/chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/app_list/start_page_service.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	trunk/src/ui/app_list/app_list_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/app_list/app_list_switches.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Jun Mukai

6 years, 11 months ago (2014-01-16 07:21:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r245184 (tree was closed).