Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 139293007: Flag-flip of app-list-voice-search. Now it's on by default. (Closed)

Created:
6 years, 11 months ago by Jun Mukai
Modified:
6 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Flag-flip of app-list-voice-search. Now it's on by default. BUG=333914 R=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
6 years, 11 months ago (2014-01-15 18:46:27 UTC) #1
xiyuan
lgtm
6 years, 11 months ago (2014-01-15 18:56:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/139293007/1
6 years, 11 months ago (2014-01-15 19:36:10 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 03:26:01 UTC) #4
Message was sent while issue was closed.
Change committed as 245093

Powered by Google App Engine
This is Rietveld 408576698