Issue 139293009: Move keyboard test from unit test to browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139293009: Move keyboard test from unit test to browser test (Closed)

Created:
6 years, 11 months ago by bshe

Modified:
6 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move keyboard test from unit test to browser test Temporarily move AshKeyboardControllerProxyTest from unit test to browser test. There is a problem with calling ui::SetUpInputMethodFactoryForTesting() in unit test right now. See comments in codereview.chromium.org/136033005 for detail. BUG=NONE R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245249

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -159 lines)			Patch
A +	chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
D	chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc	View		1 chunk	+0 lines, -156 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bshe

Hey Oshima. As discussed offline, do you mind to take a look at this CL? ...

6 years, 11 months ago (2014-01-16 00:43:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/139293009/50001

6 years, 11 months ago (2014-01-16 01:29:56 UTC) #3

bshe

6 years, 11 months ago (2014-01-16 18:08:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r245249 (presubmit successful).

Expand Messages | Collapse Messages