Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6641)

Unified Diff: chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc

Issue 139293009: Move keyboard test from unit test to browser test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc
diff --git a/chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc b/chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc
similarity index 97%
rename from chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc
rename to chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc
index 4f4da622d0a6af17a49ea7ee7c29df5d394037de..9518b072768efdb0f343b9e5d624c0cae7a24116 100644
--- a/chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc
+++ b/chrome/browser/ui/ash/ash_keyboard_controller_proxy_browsertest.cc
@@ -67,6 +67,8 @@ class TestAshKeyboardControllerProxy : public AshKeyboardControllerProxy {
DISALLOW_COPY_AND_ASSIGN(TestAshKeyboardControllerProxy);
};
+// TODO(bshe): Move this test back to unit test if
+// ui::SetUpInputMethodFactoryForTesting() is safe to be called in unit test.
class AshKeyboardControllerProxyTest : public ash::test::AshTestBase {
public:
AshKeyboardControllerProxyTest() {}
« no previous file with comments | « no previous file | chrome/browser/ui/ash/ash_keyboard_controller_proxy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698