Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13928035: WIP Component build of autofill

Created:
7 years, 8 months ago by kaiwang
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Raman Kakilate, jam, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Component build of autofill BUG=

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : make windows compiling #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -334 lines) Patch
M chrome/browser/autofill/personal_data_manager_factory.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/memory_purger.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 2 1 chunk +14 lines, -7 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 2 2 chunks +39 lines, -35 lines 0 comments Download
M components/autofill.gypi View 1 2 4 chunks +80 lines, -5 lines 0 comments Download
M components/autofill/browser/android/component_jni_registrar.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/browser/autocheckout/whitelist_manager.h View 1 2 1 chunk +108 lines, -107 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M components/autofill/browser/autofill_country.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_external_delegate.h View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_external_delegate.cc View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_field.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_ie_toolbar_import_win.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_manager.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_manager_delegate.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/browser/autofill_metrics.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_metrics_unittest.cc View 1 2 4 chunks +8 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_profile.h View 3 chunks +3 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_type.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/browser/credit_card.h View 3 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/browser/field_types.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/browser/form_group.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/form_structure.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/password_generator.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/personal_data_manager.h View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 1 2 18 chunks +33 lines, -55 lines 0 comments Download
M components/autofill/browser/personal_data_manager_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M components/autofill/browser/phone_number_i18n.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/autofill/browser/risk/fingerprint.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/autofill/browser/validation.h View 1 2 3 chunks +12 lines, -9 lines 0 comments Download
M components/autofill/browser/wallet/cart.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/wallet/full_wallet.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/wallet/instrument.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/wallet/wallet_address.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/wallet/wallet_client.h View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/browser/wallet/wallet_items.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/browser/wallet/wallet_service_url.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/browser/wallet/wallet_signin_helper.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/browser/webdata/autofill_entry.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/browser/webdata/autofill_table.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service.h View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service_observer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/common/autofill_constants.h View 1 chunk +3 lines, -1 line 0 comments Download
A components/autofill/common/autofill_export.h View 1 chunk +34 lines, -0 lines 0 comments Download
M components/autofill/common/autofill_messages.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/common/autofill_pref_names.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/common/autofill_switches.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/common/form_data.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/common/form_data_predictions.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/common/form_field_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/common/form_field_data_predictions.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/common/password_form_fill_data.h View 3 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/common/password_generation_util.h View 3 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/common/web_element_descriptor.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/renderer/autofill_agent.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/renderer/page_click_tracker.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/renderer/password_autofill_agent.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/renderer/password_generation_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/webdata/common/web_data_service_consumer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_user_data.h View 1 2 3 chunks +12 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kaiwang
https://codereview.chromium.org/13928035/diff/4001/content/public/browser/web_contents_user_data.h File content/public/browser/web_contents_user_data.h (left): https://codereview.chromium.org/13928035/diff/4001/content/public/browser/web_contents_user_data.h#oldcode70 content/public/browser/web_contents_user_data.h:70: // Please ignore the change below. It's not necessary
7 years, 8 months ago (2013-04-18 22:14:36 UTC) #1
tfarina
Kai you forgot to feel the Reviewers list.
7 years, 8 months ago (2013-04-18 22:16:09 UTC) #2
kaiwang
7 years, 8 months ago (2013-04-18 22:19:07 UTC) #3 
Thanks for reminding :)
It's still working in progress. Will ask for formal review later.


On Thu, Apr 18, 2013 at 3:16 PM, <tfarina@chromium.org> wrote:

> Kai you forgot to feel the Reviewers list.
>
>
https://codereview.chromium.**org/13928035/<https://codereview.chromium.org/1...
>



-- 
Best Regards!

Kai Wang

Powered by Google App Engine
This is Rietveld 408576698