Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1392723003: Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop (Closed)

Created:
5 years, 2 months ago by Alan Knight
Modified:
5 years, 2 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop BUG= Committed: https://github.com/dart-lang/sdk/commit/c92a2450b441192cbf811264175b2f8b57bd3f16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -757 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 326 chunks +182 lines, -482 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 10 chunks +5 lines, -15 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 66 chunks +35 lines, -100 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 8 chunks +4 lines, -12 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 67 chunks +34 lines, -100 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 11 chunks +5 lines, -20 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 chunks +10 lines, -6 lines 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
TBR
5 years, 2 months ago (2015-10-08 00:42:06 UTC) #2
Alan Knight
5 years, 2 months ago (2015-10-08 00:42:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c92a2450b441192cbf811264175b2f8b57bd3f16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698