sdk/lib/js/dartium/js_dartium.dart - Issue 1392723003: Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 1392723003: Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/js/dartium/js_dartium.dart

diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart

index eaf78716687ca532518dfecc137a45c1612508ed..13e701230724d32c0d714672d5169ed482ae7a78 100644

--- a/sdk/lib/js/dartium/js_dartium.dart

+++ b/sdk/lib/js/dartium/js_dartium.dart

@@ -733,7 +733,7 @@ void setDartHtmlWrapperFor(JsObject object, wrapper) {

* wrap_jso defined in dart:html.

unwrap_jso(dartClass_instance) {

- if (dartClass_instance is NativeFieldWrapperClass2 && dartClass_instance is! JsObject)

+ if (dartClass_instance is html.DartHtmlDomObject)

return dartClass_instance.blink_jsObject;

else

return dartClass_instance;

« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »