Extract content dependency from keyboard code

Extract content dependency from keyboard code

Move content specific stuff to content subdir.
KeyboardControllerProxy -> KeyboardUI
Restructure targets.

R=sky@chromium.org
http://crbug.com/332504

Committed: https://crrev.com/974286a2cb68813b64c27c0fcd99cdfd899a007a
Cr-Commit-Position: refs/heads/master@{#353441}

[Ben Goodger (Google), 2015-10-06 23:35:34]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-06 23:38:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392713002/1

[commit-bot: I haz the power, 2015-10-06 23:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 23:46:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2015-10-09 17:33:36]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-10-09 18:23:30]

https://codereview.chromium.org/1392713002/diff/80001/ash/test/test_keyboard_...
File ash/test/test_keyboard_ui.h (right):

https://codereview.chromium.org/1392713002/diff/80001/ash/test/test_keyboard_...
ash/test/test_keyboard_ui.h:1: // Copyright 2013 The Chromium Authors. All
rights reserved.
2015

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/BUILD.gn
File ui/keyboard/BUILD.gn (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/BUILD.gn#ne...
ui/keyboard/BUILD.gn:26: defines = [ "KEYBOARD_IMPLEMENTATION" ]
Similar comment about this define as in gyp file.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/content/key...
File ui/keyboard/content/keyboard_content_util.cc (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/content/key...
ui/keyboard/content/keyboard_content_util.cc:104: static const size_t
kKeyboardResourcesSize = arraysize(kKeyboardResources);
I wouldn't bother with the field here, move = arraysize(kKeyboardResources) to
the next line.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/content/key...
File ui/keyboard/content/keyboard_ui_content.cc (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/content/key...
ui/keyboard/content/keyboard_ui_content.cc:36:
KeyboardContentsDelegate(keyboard::KeyboardUIContent* ui) : ui_(ui) {}
explicit

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard.gyp
File ui/keyboard/keyboard.gyp (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard.gy...
ui/keyboard/keyboard.gyp:66: 'KEYBOARD_IMPLEMENTATION',
Because you're changing the type is this still necessary? It seems weird that
the type is static_library, yet you still have KEYBOARD_EXPORT in these files.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_co...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_co...
ui/keyboard/keyboard_controller.cc:392: /*
?

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui.cc
File ui/keyboard/keyboard_ui.cc (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui...
ui/keyboard/keyboard_ui.cc:30: GetKeyboardWindow()->Show();
Is it assumed that GetKeyboardWindow() always creates?

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui.h
File ui/keyboard/keyboard_ui.h (right):

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui...
ui/keyboard/keyboard_ui.h:8: #include <vector>
nit: you shouldn't need this include.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui...
ui/keyboard/keyboard_ui.h:35: // with the proxy.
proxy->'ui' or maybe 'this class'.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui...
ui/keyboard/keyboard_ui.h:39: // WebContent so we can just check if the
WebContent is created or not.
nit: this comment is out of date.

https://codereview.chromium.org/1392713002/diff/80001/ui/keyboard/keyboard_ui...
ui/keyboard/keyboard_ui.h:63: // KeyboardController owns KeyboardControllerProxy
so KeyboardControllerProxy
KeyboardControllerProxy->KeyboardUI.

[sadrul, 2015-10-09 20:14:21]

Drive-by note: CL description is the one that gets committed in git. So please
make sure to include the CL title in the CL description too!

[Ben Goodger (Google), 2015-10-09 21:36:30]

PTAL

[sky, 2015-10-09 22:01:16]

LGTM

[Ben Goodger (Google), 2015-10-09 22:13:50]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-10-09 22:13:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1392713002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2015-10-09 22:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392713002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392713002/120001

[commit-bot: I haz the power, 2015-10-09 22:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 22:30:27]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2015-10-09 23:21:42]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-10-09 23:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1392713002/#ps140001
(title: ".")

[commit-bot: I haz the power, 2015-10-09 23:24:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392713002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392713002/140001

[commit-bot: I haz the power, 2015-10-10 00:45:21]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-10-10 00:46:05]

Patchset 8 (id:??) landed as
https://crrev.com/974286a2cb68813b64c27c0fcd99cdfd899a007a
Cr-Commit-Position: refs/heads/master@{#353441}