components/autofill/core/browser/autofill_profile.h - Issue 1392623002: [Autofill] Add metric for profile action on form submitted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.h

Issue 1392623002: [Autofill] Add metric for profile action on form submitted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_metrics.cc ('K') | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | components/autofill/core/browser/autofill_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.h

diff --git a/components/autofill/core/browser/autofill_profile.h b/components/autofill/core/browser/autofill_profile.h

index f96628a5f92fd5293bbe0984c3faf3e61ec8a53e..30358bc72042e9278c2ef3b7bcde7ae696fd07f0 100644

--- a/components/autofill/core/browser/autofill_profile.h

+++ b/components/autofill/core/browser/autofill_profile.h

@@ -114,8 +114,9 @@ class AutofillProfile : public AutofillDataModel {

const std::string& app_locale,

const ServerFieldTypeSet& types) const;

- // Overwrites the field data in |profile| with this Profile.

- void OverwriteWith(const AutofillProfile& profile,

+ // Overwrites the field data in |profile| with this Profile. Returns |true| if

+ // at least one field was overwritten.

+ bool OverwriteWith(const AutofillProfile& profile,

const std::string& app_locale);