Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13925020: keyboard: Add a test suite for the tests, and initialize all the UI things properly. (Closed)

Created:
7 years, 8 months ago by sadrul
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

keyboard: Add a test suite for the tests, and initialize all the UI things properly. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194381

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/chromeos/input_method/textinput_test_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/mock_input_method.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
A + ui/keyboard/keyboard_test_suite.cc View 1 2 3 4 1 chunk +11 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
7 years, 8 months ago (2013-04-15 22:36:48 UTC) #1
bryeung
https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_controller_unittest.cc File ui/keyboard/keyboard_controller_unittest.cc (right): https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_controller_unittest.cc#newcode60 ui/keyboard/keyboard_controller_unittest.cc:60: ui::SetUpInputMethodFacotryForTesting(); typo: Factory https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_test_suite.cc File ui/keyboard/keyboard_test_suite.cc (right): https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_test_suite.cc#newcode8 ui/keyboard/keyboard_test_suite.cc:8: ...
7 years, 8 months ago (2013-04-16 14:13:34 UTC) #2
sadrul
https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_controller_unittest.cc File ui/keyboard/keyboard_controller_unittest.cc (right): https://codereview.chromium.org/13925020/diff/10001/ui/keyboard/keyboard_controller_unittest.cc#newcode60 ui/keyboard/keyboard_controller_unittest.cc:60: ui::SetUpInputMethodFacotryForTesting(); On 2013/04/16 14:13:35, bryeung wrote: > typo: Factory ...
7 years, 8 months ago (2013-04-16 15:24:56 UTC) #3
bryeung
Thanks for cleaning up the typo everywhere! lgtm https://codereview.chromium.org/13925020/diff/20001/ui/keyboard/keyboard_test_suite.cc File ui/keyboard/keyboard_test_suite.cc (right): https://codereview.chromium.org/13925020/diff/20001/ui/keyboard/keyboard_test_suite.cc#newcode7 ui/keyboard/keyboard_test_suite.cc:7: #include ...
7 years, 8 months ago (2013-04-16 15:40:50 UTC) #4
sadrul
+ben for OWNERS https://codereview.chromium.org/13925020/diff/20001/ui/keyboard/keyboard_test_suite.cc File ui/keyboard/keyboard_test_suite.cc (right): https://codereview.chromium.org/13925020/diff/20001/ui/keyboard/keyboard_test_suite.cc#newcode7 ui/keyboard/keyboard_test_suite.cc:7: #include "base/test/test_suite.h" On 2013/04/16 15:40:50, bryeung ...
7 years, 8 months ago (2013-04-16 16:02:04 UTC) #5
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-16 16:37:59 UTC) #6
sadrul
7 years, 8 months ago (2013-04-16 17:23:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as r194381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698