grit/format/policy_templates/writers/android_policy_writer.py - Issue 1392383004: Add the missing version number comment for AndroidPolicyWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/android_policy_writer.py

Issue 1392383004: Add the missing version number comment for AndroidPolicyWriter (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: grit/format/policy_templates/writers/android_policy_writer.py

diff --git a/grit/format/policy_templates/writers/android_policy_writer.py b/grit/format/policy_templates/writers/android_policy_writer.py

index 5d8cbef38f991b2964d15d36ce6f6e3b45133072..8cc447d01333699978312e965e68a878e269e1ab 100644

--- a/grit/format/policy_templates/writers/android_policy_writer.py

+++ b/grit/format/policy_templates/writers/android_policy_writer.py

@@ -88,6 +88,9 @@ class AndroidPolicyWriter(xml_formatted_writer.XMLFormattedWriter):

def BeginTemplate(self):

comment_text = 'DO NOT MODIFY THIS FILE DIRECTLY!\n' \

'IT IS GENERATED FROM policy_templates.json.'

+ if self._GetChromiumVersionString():

+ comment_text += "\n" + self.config["build"] + " version: "\

+ + self._GetChromiumVersionString()

Joao da Silva 2015/11/02 14:37:41 Can you add a test for this

comment_node = self._doc.createComment(comment_text)

self._doc.insertBefore(comment_node, self._resources)

« grit/format/policy_templates/writer_configuration.py ('K') | « grit/format/policy_templates/writer_configuration.py ('k') | no next file » | no next file with comments »