Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1392383004: Add the missing version number comment for AndroidPolicyWriter (Closed)

Created:
5 years, 2 months ago by fqj
Modified:
5 years ago
CC:
grit-developer_googlegroups.com, Andrew T Wilson (Slow)
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the missing version number comment for AndroidPolicyWriter BUG=108941

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M grit/format/policy_templates/writers/android_policy_writer.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
fqj
Hello, Could you please help review this? Thanks
5 years, 2 months ago (2015-10-12 14:11:32 UTC) #2
fqj
Hello ben, Could you please review this? Thanks
5 years, 1 month ago (2015-10-26 18:51:20 UTC) #4
Ben Goodger (Google)
On 2015/10/26 18:51:20, fqj wrote: > Hello ben, > Could you please review this? > ...
5 years, 1 month ago (2015-10-26 19:10:00 UTC) #5
fqj
Hello @flackr, Could you please review this? Sorry, @ben, cauz you're on Chromite Butler's suggested ...
5 years, 1 month ago (2015-10-26 19:14:40 UTC) #7
flackr
+joaodasilva I'm not very familiar with this part of grit.
5 years, 1 month ago (2015-10-30 14:43:06 UTC) #9
Joao da Silva
I can have a look at this one. @Drew, is there an owner of the ...
5 years, 1 month ago (2015-11-02 14:37:41 UTC) #10
fqj
Hello, I can update .gypi file to pass path for versionfile, it should be build/grit_action.gypi ...
5 years, 1 month ago (2015-11-02 17:07:06 UTC) #11
Joao da Silva
On 2015/11/02 17:07:06, fqj wrote: > Hello, > > I can update .gypi file to ...
5 years, 1 month ago (2015-11-02 17:15:52 UTC) #12
fqj
removed file parsing, only keep adding version comment to andriod. PTAL
5 years, 1 month ago (2015-11-02 17:26:31 UTC) #14
Joao da Silva
lgtm lgtm
5 years, 1 month ago (2015-11-02 17:30:44 UTC) #15
fqj
Hello flackr, Who can help to commit this?
5 years, 1 month ago (2015-11-09 18:30:01 UTC) #16
Joao da Silva
On 2015/11/09 18:30:01, fqj wrote: > Hello flackr, > Who can help to commit this? ...
5 years, 1 month ago (2015-11-10 08:36:07 UTC) #17
Mattias Nissler (ping if slow)
Nico, what's the process for submitting grit CLs these days?
5 years, 1 month ago (2015-11-19 19:02:20 UTC) #19
Mattias Nissler (ping if slow)
On 2015/11/19 19:02:20, Mattias Nissler wrote: > Nico, what's the process for submitting grit CLs ...
5 years, 1 month ago (2015-11-19 19:29:05 UTC) #20
Nico
5 years, 1 month ago (2015-11-19 19:35:42 UTC) #21
On 2015/11/19 19:29:05, Mattias Nissler wrote:
> On 2015/11/19 19:02:20, Mattias Nissler wrote:
> > Nico, what's the process for submitting grit CLs these days?
> 
> It looks like grit has become part of the main chromium repository (which
> matches the plan discussed some time ago). Can you rebase this change to apply
> to chromium/src/tools/grit?

Right, you just land them like any other chromium CL – no DEPS roll needed after
landing.

Make sure to manually run the tests though, as grit's tests aren't part of the
cq yet. (this is http://crbug.com/555695)

Powered by Google App Engine
This is Rietveld 408576698