cc/trees/layer_sorter.h - Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_sorter.h

Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected as per review comments! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_sorter.h

diff --git a/cc/trees/layer_sorter.h b/cc/trees/layer_sorter.h

index 361a5c85f75e1364604cfbdf91772333f2194b70..c5aab7ca780a59807f04dfd2e0e208ecac86c9a7 100644

--- a/cc/trees/layer_sorter.h

+++ b/cc/trees/layer_sorter.h

@@ -42,7 +42,7 @@ struct CC_EXPORT LayerShape {

LayerShape(float width, float height, const gfx::Transform& draw_transform);

~LayerShape();

- float LayerZFromProjectedPoint(gfx::PointF p) const;

+ float LayerZFromProjectedPoint(const gfx::PointF& p) const;

gfx::Vector3dF layer_normal;

gfx::Point3F transform_origin;

« no previous file with comments | « cc/resources/layer_quad.cc ('k') | cc/trees/layer_sorter.cc » ('j') | no next file with comments »