cc/resources/layer_quad.cc - Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/layer_quad.cc

Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected as per review comments! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/layer_quad.cc

diff --git a/cc/resources/layer_quad.cc b/cc/resources/layer_quad.cc

index 3e1955d05d820bedcd4114540d8174bd65902ced..fdd68662e3526259d4291485ed91ad25cda4b882 100644

--- a/cc/resources/layer_quad.cc

+++ b/cc/resources/layer_quad.cc

@@ -9,7 +9,7 @@

namespace cc {

-LayerQuad::Edge::Edge(gfx::PointF p, gfx::PointF q) {

+LayerQuad::Edge::Edge(const gfx::PointF& p, const gfx::PointF& q) {

DCHECK(p != q);

gfx::Vector2dF tangent(p.y() - q.y(), q.x() - p.x());

« no previous file with comments | « cc/resources/layer_quad.h ('k') | cc/trees/layer_sorter.h » ('j') | no next file with comments »