Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392203002: [es6] Support optional "receiver" argument in Reflect.get. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Support optional "receiver" argument in Reflect.get. Also add some more tests. R=rossberg BUG= Committed: https://crrev.com/cfe7c9c5ce90631361833b4bd97595f9bb6bff98 Cr-Commit-Position: refs/heads/master@{#31181}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Be strict again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -20 lines) Patch
M src/bootstrapper.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M src/builtins.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 4 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
neis
5 years, 2 months ago (2015-10-08 12:25:56 UTC) #1
rossberg
https://codereview.chromium.org/1392203002/diff/1/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (left): https://codereview.chromium.org/1392203002/diff/1/test/mjsunit/harmony/reflect.js#oldcode15 test/mjsunit/harmony/reflect.js:15: "use strict"; Why drop this? The language mode shouldn't ...
5 years, 2 months ago (2015-10-08 12:36:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392203002/20001
5 years, 2 months ago (2015-10-08 13:46:28 UTC) #4
neis
On 2015/10/08 12:36:34, rossberg wrote: > https://codereview.chromium.org/1392203002/diff/1/test/mjsunit/harmony/reflect.js > File test/mjsunit/harmony/reflect.js (left): > > https://codereview.chromium.org/1392203002/diff/1/test/mjsunit/harmony/reflect.js#oldcode15 > ...
5 years, 2 months ago (2015-10-08 13:47:29 UTC) #5
rossberg
lgtm
5 years, 2 months ago (2015-10-08 13:51:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 14:19:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392203002/20001
5 years, 2 months ago (2015-10-08 14:21:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-08 14:23:07 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 14:23:22 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cfe7c9c5ce90631361833b4bd97595f9bb6bff98
Cr-Commit-Position: refs/heads/master@{#31181}

Powered by Google App Engine
This is Rietveld 408576698