Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: src/bootstrapper.cc

Issue 1392203002: [es6] Support optional "receiver" argument in Reflect.get. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Be strict again. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 987c9689a6c996aeda1fdac801d1e3adb0b13f69..aaf7b6f1a25850903581fe0516ff117491be7cf6 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1891,12 +1891,16 @@ void Genesis::InitializeGlobal_harmony_tolength() {
}
-static void SimpleInstallFunction(
- Handle<JSObject>& base, const char* name, Builtins::Name call, int len) {
+static void SimpleInstallFunction(Handle<JSObject>& base, const char* name,
+ Builtins::Name call, int len, bool adapt) {
Handle<JSFunction> fun =
InstallFunction(base, name, JS_OBJECT_TYPE, JSObject::kHeaderSize,
MaybeHandle<JSObject>(), call);
- fun->shared()->set_internal_formal_parameter_count(len);
+ if (adapt) {
+ fun->shared()->set_internal_formal_parameter_count(len);
+ } else {
+ fun->shared()->DontAdaptArguments();
+ }
fun->shared()->set_length(len);
}
@@ -1913,13 +1917,13 @@ void Genesis::InitializeGlobal_harmony_reflect() {
JSObject::AddProperty(global, reflect_string, reflect, DONT_ENUM);
SimpleInstallFunction(reflect, "deleteProperty",
- Builtins::kReflectDeleteProperty, 2);
+ Builtins::kReflectDeleteProperty, 2, true);
SimpleInstallFunction(reflect, "get",
- Builtins::kReflectGet, 3);
+ Builtins::kReflectGet, 3, false);
SimpleInstallFunction(reflect, "has",
- Builtins::kReflectHas, 2);
+ Builtins::kReflectHas, 2, true);
SimpleInstallFunction(reflect, "isExtensible",
- Builtins::kReflectIsExtensible, 1);
+ Builtins::kReflectIsExtensible, 1, true);
}
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698