Allways call didReceiveAuthenticationChallenge: completion handler.

ios/web/net/cert_verifier_block_adapter.h

Index: ios/web/net/cert_verifier_block_adapter.h
diff --git a/ios/web/net/cert_verifier_block_adapter.h b/ios/web/net/cert_verifier_block_adapter.h
index 2646f91797af87df60fef528f45a5e86cf8165e4..668e6d7ae4cead897def13d90099083059671580 100644
--- a/ios/web/net/cert_verifier_block_adapter.h
+++ b/ios/web/net/cert_verifier_block_adapter.h
@@ -30,8 +30,8 @@ class CertVerifierBlockAdapter {
   CertVerifierBlockAdapter(net::CertVerifier* cert_verifier,
                            net::NetLog* net_log);
 
-  // When the verifier is destroyed, all certificate verification requests are
-  // canceled, and their completion handlers will not be called.
+  // When the verifier is destroyed, certificate verification requests are not
+  // canceled, and their completion handlers guaranteed to be called.

[Ryan Sleevi, 2015/10/28 18:32:27]

Should this be "completion handlers are guaranteed to be called"

It's unclear whether the not is conjunctive with the "and their" or not - hence
the added verb to clarify.

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

   ~CertVerifierBlockAdapter();
 
   // Encapsulates verification params. |cert| and |hostname| are mandatory, the
@@ -68,13 +68,11 @@ class CertVerifierBlockAdapter {
 
   // Verifies certificate with given |params|. |completion_handler| must not be
   // null and can be called either synchronously (in the same runloop) or
-  // asynchronously.
+  // asynchronously. |completion_handler| is guaranteed to be called even if
+  // object of this class is destroyed.

[Ryan Sleevi, 2015/10/28 18:32:27]

nit: This does not read naturally ("if object of this class is destroyed")

// asynchronously.
// Note: |completion_handler| is guaranteed to be called, even if the instance
|Verify()| was called on is destroyed.

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

   void Verify(const Params& params, CompletionHandler completion_handler);
 
  private:
-  // Pending verification requests. Request must be alive until verification is
-  // completed, otherwise verification operation will be cancelled.
-  ScopedVector<net::CertVerifier::Request> pending_requests_;
   // Underlying unowned CertVerifier.
   net::CertVerifier* cert_verifier_;
   // Unowned NetLog required by CertVerifier.