Allways call didReceiveAuthenticationChallenge: completion handler.

ios/web/net/cert_verifier_block_adapter.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_NET_CERT_VERIFIER_BLOCK_ADAPTER_H_
 #define IOS_WEB_NET_CERT_VERIFIER_BLOCK_ADAPTER_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/threading/thread_checker.h"
@@ skipping 12 matching lines @@
 // created and used on the same thread where the |net::CertVerifier| was
 // created.
 class CertVerifierBlockAdapter {
  public:
   // Constructs adapter with given |CertVerifier| and |NetLog|, both can not be
   // null. CertVerifierBlockAdapter does NOT take ownership of |cert_verifier|
   // and |net_log|.
   CertVerifierBlockAdapter(net::CertVerifier* cert_verifier,
                            net::NetLog* net_log);
 
-  // When the verifier is destroyed, all certificate verification requests are
-  // canceled, and their completion handlers will not be called.
+  // When the verifier is destroyed, certificate verification requests are not
+  // canceled, and their completion handlers guaranteed to be called.

[Ryan Sleevi, 2015/10/28 18:32:27]

Should this be "completion handlers are guaranteed to be called"

It's unclear whether the not is conjunctive with the "and their" or not - hence
the added verb to clarify.

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

   ~CertVerifierBlockAdapter();
 
   // Encapsulates verification params. |cert| and |hostname| are mandatory, the
   // other params are optional. If either of mandatory arguments is null or
   // empty then verification |CompletionHandler| will be called with
   // ERR_INVALID_ARGUMENT |error|.
   struct Params {
     // Constructs Params from X509 cert and hostname, which are mandatory for
     // verification.
     Params(const scoped_refptr<net::X509Certificate>& cert,
@@ skipping 16 matching lines @@
     // checks over the network.
     scoped_refptr<net::CRLSet> crl_set;
   };
 
   // Type of verification completion block. If cert is successfully validated
   // |error| is OK, otherwise |error| is a net error code.
   typedef void (^CompletionHandler)(net::CertVerifyResult result, int error);
 
   // Verifies certificate with given |params|. |completion_handler| must not be
   // null and can be called either synchronously (in the same runloop) or
-  // asynchronously.
+  // asynchronously. |completion_handler| is guaranteed to be called even if
+  // object of this class is destroyed.

[Ryan Sleevi, 2015/10/28 18:32:27]

nit: This does not read naturally ("if object of this class is destroyed")

// asynchronously.
// Note: |completion_handler| is guaranteed to be called, even if the instance
|Verify()| was called on is destroyed.

[Eugene But (OOO till 7-30), 2015/10/29 15:43:38]

Done.

   void Verify(const Params& params, CompletionHandler completion_handler);
 
  private:
-  // Pending verification requests. Request must be alive until verification is
-  // completed, otherwise verification operation will be cancelled.
-  ScopedVector<net::CertVerifier::Request> pending_requests_;
   // Underlying unowned CertVerifier.
   net::CertVerifier* cert_verifier_;
   // Unowned NetLog required by CertVerifier.
   net::NetLog* net_log_;
   // CertVerifierBlockAdapter should be used on the same thread where it was
   // created.
   base::ThreadChecker thread_checker_;
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_NET_CERT_VERIFIER_BLOCK_ADAPTER_H_