Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392143002: Add context to OptionsProcessor callback API. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Master merge #

Total comments: 2

Patch Set 3 : Arg reordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/plugin/options.dart View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/plugin_configuration.dart View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 3 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-07 23:28:32 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1392143002/diff/20001/pkg/analyzer/lib/plugin/options.dart File pkg/analyzer/lib/plugin/options.dart (right): https://codereview.chromium.org/1392143002/diff/20001/pkg/analyzer/lib/plugin/options.dart#newcode62 pkg/analyzer/lib/plugin/options.dart:62: void optionsProcessed(Map<String, YamlNode> options, AnalysisContext context); nit: In ...
5 years, 2 months ago (2015-10-08 16:46:47 UTC) #3
pquitslund
Updated. Thanks! https://codereview.chromium.org/1392143002/diff/20001/pkg/analyzer/lib/plugin/options.dart File pkg/analyzer/lib/plugin/options.dart (right): https://codereview.chromium.org/1392143002/diff/20001/pkg/analyzer/lib/plugin/options.dart#newcode62 pkg/analyzer/lib/plugin/options.dart:62: void optionsProcessed(Map<String, YamlNode> options, AnalysisContext context); On ...
5 years, 2 months ago (2015-10-08 17:09:05 UTC) #4
pquitslund
5 years, 2 months ago (2015-10-08 17:47:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e19f10fbec62e6bfaf3144e04d735769be05e77b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698