Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1392143002: Add context to OptionsProcessor callback API. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Arg reordering. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/CHANGELOG.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index f81f5b8eb4b76a95d907dabd6e9211eda5a77e1b..b10967a6861048252ca8c16bfa8441400a3903e5 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -467,12 +467,17 @@ class ContextManagerImpl implements ContextManager {
*/
void processOptionsForContext(
ContextInfo info, Map<String, YamlNode> options) {
- //TODO(pquitslund): push handling into an options processor plugin contributed to engine.
- //AnalysisEngine.instance.optionsPlugin.optionsProcessors
- // .forEach((OptionsProcessor p) => p.optionsProcessed(options));
if (options == null) {
return;
}
+
+ // Notify options processors.
+ AnalysisEngine.instance.optionsPlugin.optionsProcessors
+ .forEach(
+ (OptionsProcessor p) => p.optionsProcessed(options, info.context));
+
+ // Analysis options are processed 'in-line'.
+ // TODO(pq): consider pushing exclude handling into a plugin.
YamlMap analyzer = options['analyzer'];
if (analyzer == null) {
// No options for analyzer.
« no previous file with comments | « no previous file | pkg/analyzer/CHANGELOG.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698