Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: snapshot/win/exception_snapshot_win_test.cc

Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/end_to_end_test.py ('k') | snapshot/win/process_snapshot_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/exception_snapshot_win_test.cc
diff --git a/snapshot/win/exception_snapshot_win_test.cc b/snapshot/win/exception_snapshot_win_test.cc
index 3fc8c6d16fd2a23d5a312bd74f2ef8fa8bfa32bf..7c3b3691409cb682b626a3239eca8cbd3984c6d3 100644
--- a/snapshot/win/exception_snapshot_win_test.cc
+++ b/snapshot/win/exception_snapshot_win_test.cc
@@ -88,10 +88,13 @@ class CrashingDelegate : public ExceptionHandlerServer::Delegate {
unsigned int ExceptionHandlerServerException(
HANDLE process,
- WinVMAddress exception_information_address) override {
+ WinVMAddress exception_information_address,
+ WinVMAddress debug_critical_section_address) override {
ScopedProcessSuspend suspend(process);
ProcessSnapshotWin snapshot;
- snapshot.Initialize(process, ProcessSuspensionState::kSuspended);
+ snapshot.Initialize(process,
+ ProcessSuspensionState::kSuspended,
+ debug_critical_section_address);
snapshot.InitializeException(exception_information_address);
// Confirm the exception record was read correctly.
@@ -186,10 +189,13 @@ class SimulateDelegate : public ExceptionHandlerServer::Delegate {
unsigned int ExceptionHandlerServerException(
HANDLE process,
- WinVMAddress exception_information_address) override {
+ WinVMAddress exception_information_address,
+ WinVMAddress debug_critical_section_address) override {
ScopedProcessSuspend suspend(process);
ProcessSnapshotWin snapshot;
- snapshot.Initialize(process, ProcessSuspensionState::kSuspended);
+ snapshot.Initialize(process,
+ ProcessSuspensionState::kSuspended,
+ debug_critical_section_address);
snapshot.InitializeException(exception_information_address);
EXPECT_TRUE(snapshot.Exception());
EXPECT_EQ(0x517a7ed, snapshot.Exception()->Exception());
« no previous file with comments | « snapshot/win/end_to_end_test.py ('k') | snapshot/win/process_snapshot_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698