Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/crashpad_info_client_options_test.cc ('k') | snapshot/win/exception_snapshot_win_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/end_to_end_test.py
diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py
index bbf442eee09bbd9d725575d63f29a0369f56080c..4217940934ccc9f74fc51e7ff36eb80c4218a424 100644
--- a/snapshot/win/end_to_end_test.py
+++ b/snapshot/win/end_to_end_test.py
@@ -177,12 +177,10 @@ def RunTests(cdb_path, dump_path, pipe_name):
out.Check('LastStatusValue: \(NTSTATUS\) 0xc000000f - {File Not Found} The '
'file %hs does not exist.', '!gle gets last ntstatus')
- # Locks.
- if False: # The code for these isn't landed yet.
- out = CdbRun(cdb_path, dump_path, '!locks')
- out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
- r'g_test_critical_section', 'lock was captured')
- out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
+ out = CdbRun(cdb_path, dump_path, '!locks')
+ out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
+ r'g_test_critical_section', 'lock was captured')
+ out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
def main(args):
« no previous file with comments | « snapshot/crashpad_info_client_options_test.cc ('k') | snapshot/win/exception_snapshot_win_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698