Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1392093003: win: Capture some CRITICAL_SECTION debugging data (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: reenable !locks test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/win/end_to_end_test.py
diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py
index bbf442eee09bbd9d725575d63f29a0369f56080c..00fe71a4c9d066d8af5a6c6c4766478ad70d5056 100644
--- a/snapshot/win/end_to_end_test.py
+++ b/snapshot/win/end_to_end_test.py
@@ -178,11 +178,10 @@ def RunTests(cdb_path, dump_path, pipe_name):
'file %hs does not exist.', '!gle gets last ntstatus')
# Locks.
Mark Mentovai 2015/10/15 00:14:56 There isn’t a # comment for any of the other class
scottmg 2015/10/15 18:22:23 Done.
- if False: # The code for these isn't landed yet.
- out = CdbRun(cdb_path, dump_path, '!locks')
- out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
- r'g_test_critical_section', 'lock was captured')
- out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
+ out = CdbRun(cdb_path, dump_path, '!locks')
+ out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
+ r'g_test_critical_section', 'lock was captured')
+ out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
def main(args):

Powered by Google App Engine
This is Rietveld 408576698