win: Capture some CRITICAL_SECTION debugging data

snapshot/win/end_to_end_test.py

 #!/usr/bin/env python
 
 # Copyright 2015 The Crashpad Authors. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
@@ skipping 159 matching lines @@
   out.Check(r'TEB at', 'found the TEB')
   out.Check(r'ExceptionList:\s+[0-9a-fA-F]+', 'some valid teb data')
   out.Check(r'LastErrorValue:\s+2', 'correct LastErrorValue')
 
   out = CdbRun(cdb_path, dump_path, '!gle')
   out.Check('LastErrorValue: \(Win32\) 0x2 \(2\) - The system cannot find the '
             'file specified.', '!gle gets last error')
   out.Check('LastStatusValue: \(NTSTATUS\) 0xc000000f - {File Not Found}  The '
             'file %hs does not exist.', '!gle gets last ntstatus')
 
   # Locks.

[Mark Mentovai, 2015/10/15 00:14:56]

There isn’t a # comment for any of the other classes. You can lose this (!locks
is obvious) or add comments for the other things you test here.

[scottmg, 2015/10/15 18:22:23]

Done.

-  if False:  # The code for these isn't landed yet.
-    out = CdbRun(cdb_path, dump_path, '!locks')
-    out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
-              r'g_test_critical_section', 'lock was captured')
-    out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
+  out = CdbRun(cdb_path, dump_path, '!locks')
+  out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
+            r'g_test_critical_section', 'lock was captured')
+  out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
 
 
 def main(args):
   try:
     if len(args) != 1:
       print >>sys.stderr, 'must supply binary dir'
       return 1
 
     cdb_path = GetCdbPath()
     if not cdb_path:
@@ skipping 15 matching lines @@
 
     RunTests(cdb_path, dump_path, pipe_name)
 
     return 0
   finally:
     CleanUpTempDirs()
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))