Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1391993004: WebApp splashscreen: add UMA to record how a splashscreen is constructed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4e38e93a8c96b0f2d7e3233f039dccf53fbf18ca..87307bb3410175036882153a877c3dfa06fe0742 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -50041,6 +50041,47 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>HTTP response codes seen by Wallet client.</summary>
</histogram>
+<histogram name="Webapp.Splashscreen.BackgroundColor"
+ enum="SplashscreenColorStatus">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>
+ Records the status of the splashscreen's background color (default or
+ custom).
+ </summary>
+</histogram>
+
+<histogram name="Webapp.Splashscreen.Duration" units="ms">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>Records the time during which the splashscreen was visible.</summary>
+</histogram>
+
+<histogram name="Webapp.Splashscreen.Hides" enum="SplashscreenHidesReason">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>Records the signal that was used to hide the splashscreen.</summary>
+</histogram>
+
+<histogram name="Webapp.Splashscreen.Icon.Size" units="dp">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>
+ Records the size of the icon used to construct the splashscreen in device
+ pixels (ie. real size divided by device pixel density).
Alexei Svitkine (slow) 2015/10/21 17:28:55 Is this the area of it? (i.e. width x height) If
Alexei Svitkine (slow) 2015/10/21 17:30:43 Er, not even 100x100 ;).
mlamouri (slow - plz ping) 2015/10/21 18:02:58 It's only one dimension. I've updated the CL to ma
+ </summary>
+</histogram>
+
+<histogram name="Webapp.Splashscreen.Icon.Type" enum="SplashscreenIconType">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>
+ Records the origin of the icon used to construct the splashscreen.
+ </summary>
+</histogram>
+
+<histogram name="Webapp.Splashscreen.ThemeColor" enum="SplashscreenColorStatus">
+ <owner>mlamouri@chromium.org</owner>
+ <summary>
+ Records the status of the splashscreen's theme color (default or custom).
+ </summary>
+</histogram>
+
<histogram name="WebController.ExternalURLRequestBlocking"
enum="IOSExternalURLRequestStatus">
<owner>jyquinn@chromium.org</owner>
@@ -72311,6 +72352,24 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Needs restore"/>
</enum>
+<enum name="SplashscreenColorStatus" type="int">
+ <int value="0" label="Default color"/>
+ <int value="1" label="Custom color"/>
+</enum>
+
+<enum name="SplashscreenHidesReason" type="int">
+ <int value="0" label="First Paint"/>
+ <int value="1" label="Page Load Finished"/>
+ <int value="2" label="Page Load Failed"/>
+ <int value="3" label="Crash"/>
+</enum>
+
+<enum name="SplashscreenIconType" type="int">
+ <int value="0" label="No splashscreen icon"/>
+ <int value="1" label="Fallback icon"/>
+ <int value="2" label="Custom icon"/>
+</enum>
+
<enum name="SqliteErrorCode" type="int">
<summary>Error codes returned by SQLite - see sqlite3.h</summary>
<int value="0" label="SQLITE_OK">Successful result</int>

Powered by Google App Engine
This is Rietveld 408576698