Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4317)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java

Issue 1391993004: WebApp splashscreen: add UMA to record how a splashscreen is constructed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
index 675a6bfc97243148eb8ffd7f64f5fde2c37de8b6..beb56c33e21c29c2ab994bb9a56394a5e6d737da 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
@@ -12,15 +12,17 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.browser.ShortcutHelper;
+import org.chromium.chrome.browser.metrics.WebappUma;
import org.chromium.chrome.browser.tab.TabObserver;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
/**
- * Tests for splashscreen.
+ * Tests for splash screens with EXTRA_THEME_COLOR specified in the Intent.
*/
public class WebappSplashScreenThemeColorTest extends WebappActivityTestBase {
@@ -70,4 +72,12 @@ public class WebappSplashScreenThemeColorTest extends WebappActivityTestBase {
}
}));
}
+
+ @SmallTest
+ @Feature({"Webapps"})
+ public void testUmaThemeColorCustom() {
+ assertEquals(1, RecordHistogram.getHistogramValueCountForTesting(
+ HISTOGRAM_SPLASHSCREEN_THEMECOLOR,
+ WebappUma.SPLASHSCREEN_COLOR_STATUS_CUSTOM));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698