Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 1391943005: Document reflection (Closed)

Created:
5 years, 2 months ago by Julien - ping for review
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document reflection Added some class description to the 3 objects used in reflection. Tried to explain as much of the design as I could but had to leave some out as I didn't fully understand it (put a TODO for this instead). Also touched a bit the code to better match the intent: some paint flags were set in a caller instead of in PaintLayerReflectionInfo or a function never called wasn't marked as such. Committed: https://crrev.com/e863d1309ee8940293ea51f7b26d02cbeedc5f9c Cr-Commit-Position: refs/heads/master@{#353920}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed the TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutReplica.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplica.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.h View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ReplicaPainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplicaPainter.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Julien - ping for review
+Morten as the iron-fisted grammar viking! Not really up your alley but I don't think ...
5 years, 2 months ago (2015-10-13 02:08:19 UTC) #2
mstensho (USE GERRIT)
This Viking is in southern France, and I've temporarily lost all my grammar power. :( ...
5 years, 2 months ago (2015-10-13 16:17:45 UTC) #3
Julien - ping for review
http://4.bp.blogspot.com/-FiVJZAuxzdQ/TZkYs_5JIVI/AAAAAAAAAHg/2wltVdp3ix0/s400/Grammar%2Bis%2BDead%253F.jpg !!! https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/core/layout/LayoutReplica.h File third_party/WebKit/Source/core/layout/LayoutReplica.h (right): https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/core/layout/LayoutReplica.h#newcode58 third_party/WebKit/Source/core/layout/LayoutReplica.h:58: // TODO(jchaffraix): This description is not great ...
5 years, 2 months ago (2015-10-13 21:36:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391943005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391943005/20001
5 years, 2 months ago (2015-10-13 21:44:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 00:11:40 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:13:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e863d1309ee8940293ea51f7b26d02cbeedc5f9c
Cr-Commit-Position: refs/heads/master@{#353920}

Powered by Google App Engine
This is Rietveld 408576698