Document reflection

Document reflection

Added some class description to the 3 objects used in reflection.
Tried to explain as much of the design as I could but had to leave
some out as I didn't fully understand it (put a TODO for this instead).

Also touched a bit the code to better match the intent: some paint
flags were set in a caller instead of in PaintLayerReflectionInfo or
a function never called wasn't marked as such.

Committed: https://crrev.com/e863d1309ee8940293ea51f7b26d02cbeedc5f9c
Cr-Commit-Position: refs/heads/master@{#353920}

[Julien - ping for review, 2015-10-13 02:08:18]

jchaffraix@chromium.org changed reviewers:
+ mstensho@opera.com

[Julien - ping for review, 2015-10-13 02:08:19]

+Morten as the iron-fisted grammar viking! Not really up your alley but I don't
think it's up anyone :(

[mstensho (USE GERRIT), 2015-10-13 16:17:45]

This Viking is in southern France, and I've temporarily lost all my grammar
power. :(

lgtm :)

https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutReplica.h (right):

https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutReplica.h:58: // TODO(jchaffraix):
This description is not great but I don't know why this
I think this is just great. Nothing left TODO. :)

[Julien - ping for review, 2015-10-13 21:36:43]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2015-10-13 21:36:43]

http://4.bp.blogspot.com/-FiVJZAuxzdQ/TZkYs_5JIVI/AAAAAAAAAHg/2wltVdp3ix0/s40...
!!!

https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutReplica.h (right):

https://codereview.chromium.org/1391943005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutReplica.h:58: // TODO(jchaffraix):
This description is not great but I don't know why this
On 2015/10/13 at 16:17:45, mstensho wrote:
> I think this is just great. Nothing left TODO. :)

Not going to argue with you :)

I am not happy that I couldn't find the exact reason for the class though and it
may be that there is none.

[Julien - ping for review, 2015-10-13 21:36:59]

The CQ bit was unchecked by jchaffraix@chromium.org

[Julien - ping for review, 2015-10-13 21:37:28]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2015-10-13 21:37:28]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/1391943005/#ps20001
(title: "Removed the TODO.")

[commit-bot: I haz the power, 2015-10-13 21:44:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1391943005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1391943005/20001

[commit-bot: I haz the power, 2015-10-14 00:11:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-14 00:13:05]

Patchset 2 (id:??) landed as
https://crrev.com/e863d1309ee8940293ea51f7b26d02cbeedc5f9c
Cr-Commit-Position: refs/heads/master@{#353920}