Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1391893003: NOT FOR REVIEW: Aura on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index eaaf1c8cf4158f04ce2507f1f14e1eb255a966ef..7582ae758437ea93fe15cb49b8927eaae8b39459 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -25,7 +25,7 @@
#include "content/public/browser/navigation_details.h"
#include "ui/base/l10n/l10n_util.h"
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
#include "chrome/browser/android/chrome_application.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/password_manager/account_chooser_infobar_delegate_android.h"
@@ -72,7 +72,7 @@ void ManagePasswordsUIController::UpdateBubbleAndIconVisibility() {
passwords_data_.OnInactive();
}
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (!browser)
return;
@@ -84,7 +84,7 @@ void ManagePasswordsUIController::UpdateBubbleAndIconVisibility() {
void ManagePasswordsUIController::
UpdateAndroidAccountChooserInfoBarVisibility() {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
AccountChooserInfoBarDelegateAndroid::Create(
InfoBarService::FromWebContents(web_contents()), this);
should_pop_up_bubble_ = false;
@@ -121,7 +121,7 @@ bool ManagePasswordsUIController::OnChooseCredentials(
federated_credentials.Pass(),
origin);
base::AutoReset<bool> resetter(&should_pop_up_bubble_, true);
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
UpdateAndroidAccountChooserInfoBarVisibility();
#else
UpdateBubbleAndIconVisibility();
@@ -171,7 +171,7 @@ void ManagePasswordsUIController::OnLoginsChanged(
}
void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
chrome::android::ChromeApplication::ShowPasswordSettings();
#else
chrome::ShowSettingsSubPage(
@@ -181,7 +181,7 @@ void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
}
void ManagePasswordsUIController::NavigateToExternalPasswordManager() {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
NOTREACHED();
#else
chrome::NavigateParams params(
@@ -335,7 +335,7 @@ void ManagePasswordsUIController::DidNavigateMainFrame(
}
void ManagePasswordsUIController::WasHidden() {
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
TabDialogs::FromWebContents(web_contents())->HideManagePasswordsBubble();
#endif
}
@@ -379,7 +379,7 @@ void ManagePasswordsUIController::OnBubbleHidden() {
void ManagePasswordsUIController::ShowBubbleWithoutUserInteraction() {
DCHECK(should_pop_up_bubble_);
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (!browser || browser->toolbar_model()->input_in_progress())
return;

Powered by Google App Engine
This is Rietveld 408576698