Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6060)

Unified Diff: chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc

Issue 1391893003: NOT FOR REVIEW: Aura on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc
diff --git a/chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc b/chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc
index 63763c378cb6af3c75e13073e73c12f7da370bcb..e3692649093d6a3f68c5c836e7230f81b2b12cfe 100644
--- a/chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc
+++ b/chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc
@@ -18,11 +18,13 @@
namespace {
void AcknowledgeInPrefs(PrefService* prefs) {
+#if !defined(OS_ANDROID)
prefs->SetBoolean(prefs::kToolbarIconSurfacingBubbleAcknowledged, true);
// Once the bubble is acknowledged, we no longer need to store the last
// show time.
if (prefs->HasPrefPath(prefs::kToolbarIconSurfacingBubbleLastShowTime))
prefs->ClearPref(prefs::kToolbarIconSurfacingBubbleLastShowTime);
+#endif
}
} // namespace
@@ -38,6 +40,7 @@ ExtensionToolbarIconSurfacingBubbleDelegate::
bool ExtensionToolbarIconSurfacingBubbleDelegate::ShouldShowForProfile(
Profile* profile) {
+#if !defined(OS_ANDROID)
// If the redesign isn't running, or the user has already acknowledged it,
// we don't show the bubble.
PrefService* prefs = profile->GetPrefs();
@@ -61,6 +64,7 @@ bool ExtensionToolbarIconSurfacingBubbleDelegate::ShouldShowForProfile(
AcknowledgeInPrefs(prefs);
return false;
}
+#endif
return true;
}
@@ -93,10 +97,12 @@ ExtensionToolbarIconSurfacingBubbleDelegate::GetLearnMoreButtonText() {
}
void ExtensionToolbarIconSurfacingBubbleDelegate::OnBubbleShown() {
+#if !defined(OS_ANDROID)
// Record the last time the bubble was shown.
profile_->GetPrefs()->SetInt64(
prefs::kToolbarIconSurfacingBubbleLastShowTime,
base::Time::Now().ToInternalValue());
+#endif
}
void ExtensionToolbarIconSurfacingBubbleDelegate::OnBubbleClosed(

Powered by Google App Engine
This is Rietveld 408576698