Issue 13916007: Linux: use -Wl,--no-as-needed for all cases where it is needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13916007: Linux: use -Wl,--no-as-needed for all cases where it is needed.

Created:
7 years, 8 months ago by Lei Zhang

Modified:
6 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux: use -Wl,--no-as-needed for all cases where it is needed.

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	build/common.gypi	View		2 chunks	+4 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

7 years, 8 months ago (2013-04-12 19:42:13 UTC) #2

LGTM, thank you.

https://codereview.chromium.org/13916007/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/13916007/diff/1/build/common.gypi#newcode3116
build/common.gypi:3116: 'ldflags': [
It's hard to review changes in long and deeply nested gyp files.

I'm assuming this applies to Linux in all configurations on all architectures.

I'm relying on the trybots/buildbots to verify the correctness of this change
("if it compiles, it is perfect").

Expand Messages | Collapse Messages