Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: build/common.gypi

Issue 13916007: Linux: use -Wl,--no-as-needed for all cases where it is needed. Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2595 matching lines...) Expand 10 before | Expand all | Expand 10 after
2606 '-fomit-frame-pointer', 2606 '-fomit-frame-pointer',
2607 '-fdata-sections', 2607 '-fdata-sections',
2608 '-ffunction-sections', 2608 '-ffunction-sections',
2609 ], 2609 ],
2610 'ldflags': [ 2610 'ldflags': [
2611 '-Wl,-O1', 2611 '-Wl,-O1',
2612 '-Wl,--as-needed', 2612 '-Wl,--as-needed',
2613 '-Wl,--gc-sections', 2613 '-Wl,--gc-sections',
2614 ], 2614 ],
2615 }], 2615 }],
2616 ['OS=="linux" and target_arch=="ia32"', {
2617 'ldflags': [
2618 '-Wl,--no-as-needed',
2619 ],
2620 }],
2621 ], 2616 ],
2622 }, 2617 },
2623 'Release_Base': { 2618 'Release_Base': {
2624 'variables': { 2619 'variables': {
2625 'release_optimize%': '2', 2620 'release_optimize%': '2',
2626 # Binaries become big and gold is unable to perform GC 2621 # Binaries become big and gold is unable to perform GC
2627 # and remove unused sections for some of test targets 2622 # and remove unused sections for some of test targets
2628 # on 32 bit platform. 2623 # on 32 bit platform.
2629 # (This is currently observed only in chromeos valgrind bots) 2624 # (This is currently observed only in chromeos valgrind bots)
2630 # The following flag is to disable --gc-sections linker 2625 # The following flag is to disable --gc-sections linker
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
3110 'gold_path': '<(PRODUCT_DIR)/../../third_party/gold', 3105 'gold_path': '<(PRODUCT_DIR)/../../third_party/gold',
3111 }, { 3106 }, {
3112 'gold_path': '<(PRODUCT_DIR)/../../Source/WebKit/chromium/thir d_party/gold', 3107 'gold_path': '<(PRODUCT_DIR)/../../Source/WebKit/chromium/thir d_party/gold',
3113 }] 3108 }]
3114 ] 3109 ]
3115 }, 3110 },
3116 'ldflags': [ 3111 'ldflags': [
3117 # Put our gold binary in the search path for the linker. 3112 # Put our gold binary in the search path for the linker.
3118 '-B<(gold_path)', 3113 '-B<(gold_path)',
3119 ], 3114 ],
3115 }, {
3116 'ldflags': [
Paweł Hajdan Jr. 2013/04/12 19:42:13 It's hard to review changes in long and deeply nes
3117 '-Wl,--no-as-needed',
3118 ],
3120 }], 3119 }],
3121 ], 3120 ],
3122 }, 3121 },
3123 }], 3122 }],
3124 # FreeBSD-specific options; note that most FreeBSD options are set above, 3123 # FreeBSD-specific options; note that most FreeBSD options are set above,
3125 # with Linux. 3124 # with Linux.
3126 ['OS=="freebsd"', { 3125 ['OS=="freebsd"', {
3127 'target_defaults': { 3126 'target_defaults': {
3128 'ldflags': [ 3127 'ldflags': [
3129 '-Wl,--no-keep-memory', 3128 '-Wl,--no-keep-memory',
(...skipping 1099 matching lines...) Expand 10 before | Expand all | Expand 10 after
4229 # settings in target dicts. SYMROOT is a special case, because many other 4228 # settings in target dicts. SYMROOT is a special case, because many other
4230 # Xcode variables depend on it, including variables such as 4229 # Xcode variables depend on it, including variables such as
4231 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4230 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4232 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4231 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4233 # files to appear (when present) in the UI as actual files and not red 4232 # files to appear (when present) in the UI as actual files and not red
4234 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4233 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4235 # and therefore SYMROOT, needs to be set at the project level. 4234 # and therefore SYMROOT, needs to be set at the project level.
4236 'SYMROOT': '<(DEPTH)/xcodebuild', 4235 'SYMROOT': '<(DEPTH)/xcodebuild',
4237 }, 4236 },
4238 } 4237 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698