third_party/WebKit/Source/modules/fetch/RequestInit.h - Issue 1391583002: Introduce "navigate" mode in Requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestInit.h

Issue 1391583002: Introduce "navigate" mode in Requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/RequestInit.h

diff --git a/third_party/WebKit/Source/modules/fetch/RequestInit.h b/third_party/WebKit/Source/modules/fetch/RequestInit.h

index 6a642de42ff837c76bf75f408ab50bb9cf49a7e9..adbc74c03efe5ec89007699254dd500480ff3d09 100644

--- a/third_party/WebKit/Source/modules/fetch/RequestInit.h

+++ b/third_party/WebKit/Source/modules/fetch/RequestInit.h

@@ -38,8 +38,9 @@ public:

// https://w3c.github.io/webappsec/specs/credentialmanagement/#monkey-patching-fetch-2

bool opaque;

// True if any members in RequestInit are set and hence the referrer member

+ // so prefer using isAnyMembersSet instead isReferrerSet

yhirano 2015/10/16 18:15:53 ??

shiva.jm 2015/10/19 09:03:49 Done.

// should be used in the Request constructor.

- bool isReferrerSet;

+ bool isAnyMembersSet;

yhirano 2015/10/16 18:15:53 |areAnyMembersSet| would be better.

shiva.jm 2015/10/19 09:03:49 Done.

};

}