third_party/WebKit/Source/modules/fetch/RequestInit.h - Issue 1391583002: Introduce "navigate" mode in Requests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/fetch/RequestInit.h

Issue 1391583002: Introduce "navigate" mode in Requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/fetch/Request.cpp ('K') | « third_party/WebKit/Source/modules/fetch/Request.idl ('k') | third_party/WebKit/Source/modules/fetch/RequestInit.cpp » ('j') | third_party/WebKit/Source/modules/fetch/RequestInit.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef RequestInit_h	5 #ifndef RequestInit_h

6 #define RequestInit_h	6 #define RequestInit_h

7	7

8 #include "bindings/core/v8/Dictionary.h"	8 #include "bindings/core/v8/Dictionary.h"

9 #include "platform/heap/Handle.h"	9 #include "platform/heap/Handle.h"

10 #include "platform/weborigin/Referrer.h"	10 #include "platform/weborigin/Referrer.h"

(...skipping 20 matching lines...) Expand all Loading...
31 OwnPtr<FetchDataConsumerHandle> body;	31 OwnPtr<FetchDataConsumerHandle> body;

32 Referrer referrer;	32 Referrer referrer;

33 String mode;	33 String mode;

34 String credentials;	34 String credentials;

35 String redirect;	35 String redirect;

36 String integrity;	36 String integrity;

37	37

38 // https://w3c.github.io/webappsec/specs/credentialmanagement/#monkey-patchi ng-fetch-2	38 // https://w3c.github.io/webappsec/specs/credentialmanagement/#monkey-patchi ng-fetch-2

39 bool opaque;	39 bool opaque;

40 // True if any members in RequestInit are set and hence the referrer member	40 // True if any members in RequestInit are set and hence the referrer member

	41 // so prefer using isAnyMembersSet instead isReferrerSet
	yhirano 2015/10/16 18:15:53 ?? ?? shiva.jm 2015/10/19 09:03:49 Done. Show quoted text On 2015/10/16 18:15:53, yhirano wrote: > ?? Done.
41 // should be used in the Request constructor.	42 // should be used in the Request constructor.

42 bool isReferrerSet;	43 bool isAnyMembersSet;
	yhirano 2015/10/16 18:15:53 \|areAnyMembersSet\| would be better. \|areAnyMembersSet\| would be better. shiva.jm 2015/10/19 09:03:49 Done. Show quoted text On 2015/10/16 18:15:53, yhirano wrote: > \|areAnyMembersSet\| would be better. Done.
43 };	44 };

44	45

45 }	46 }

46	47

47 #endif // RequestInit_h	48 #endif // RequestInit_h

OLD	NEW