Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 13915011: Add support for using glCopyTexSubImage2D when possible to copy surfaces. (Closed)

Created:
7 years, 8 months ago by bsalomon
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add support for using glCopyTexSubImage2D when possible to copy surfaces. Committed: https://code.google.com/p/skia/source/detail?r=8675

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -67 lines) Patch
M src/gpu/GrDrawTarget.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 4 chunks +145 lines, -62 lines 6 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
7 years, 8 months ago (2013-04-12 20:56:58 UTC) #1
robertphillips
lgtm + some nits https://codereview.chromium.org/13915011/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/13915011/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode2275 src/gpu/gl/GrGpuGL.cpp:2275: "its (non-zero) ID is returned"? ...
7 years, 8 months ago (2013-04-15 13:01:08 UTC) #2
bsalomon
https://codereview.chromium.org/13915011/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/13915011/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode2275 src/gpu/gl/GrGpuGL.cpp:2275: On 2013/04/15 13:01:08, robertphillips wrote: > "its (non-zero) ID ...
7 years, 8 months ago (2013-04-15 13:51:01 UTC) #3
bsalomon
7 years, 8 months ago (2013-04-15 13:51:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698