chrome/browser/unload_browsertest.cc - Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/unload_browsertest.cc

Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_resource_throttle_unittest.cc ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/unload_browsertest.cc

diff --git a/chrome/browser/unload_browsertest.cc b/chrome/browser/unload_browsertest.cc

index 51aea158826c9bc6885613af683c57dd443d896b..3a368cd00bcddc9bf323bf262e7744c355e5ad44 100644

--- a/chrome/browser/unload_browsertest.cc

+++ b/chrome/browser/unload_browsertest.cc

@@ -147,8 +147,7 @@ class UnloadTest : public InProcessBrowserTest {

}

void NavigateToNolistenersFileTwice() {

- GURL url(net::URLRequestMockHTTPJob::GetMockUrl(

- base::FilePath(FILE_PATH_LITERAL("title2.html"))));

+ GURL url(net::URLRequestMockHTTPJob::GetMockUrl("title2.html"));

ui_test_utils::NavigateToURL(browser(), url);

CheckTitle("Title Of Awesomeness");

ui_test_utils::NavigateToURL(browser(), url);

@@ -159,8 +158,7 @@ class UnloadTest : public InProcessBrowserTest {

// load is purposely async to test the case where the user loads another

// page without waiting for the first load to complete.

void NavigateToNolistenersFileTwiceAsync() {

- GURL url(net::URLRequestMockHTTPJob::GetMockUrl(

- base::FilePath(FILE_PATH_LITERAL("title2.html"))));

+ GURL url(net::URLRequestMockHTTPJob::GetMockUrl("title2.html"));

ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB, 0);

ui_test_utils::NavigateToURL(browser(), url);

CheckTitle("Title Of Awesomeness");