Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 13914003: Fix detection of indexed properties in Object.defineProperty() (Closed)

Created:
7 years, 8 months ago by Jens Widell
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Daniel Bratell
Visibility:
Public.

Description

Fix detection of indexed properties in Object.defineProperty() When defining an indexed property on an Array object, the object's length property should (perhaps) be updated. This was done for any property for which ToUInt32(name) == ToNumber(name) was true, meaning any property name that, when converted to a number, was an integer in the range [0, 2^32). The detection should be more strict; an indexed property is one for which ToString(ToUInt32(name)) == name is true only. Committed: http://code.google.com/p/v8/source/detail?r=14242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/object-define-property.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jens Widell
Fixing a minor issue where Object.defineProperty() incorrectly updates .length on Array objects.
7 years, 8 months ago (2013-04-11 11:29:38 UTC) #1
Michael Starzinger
LGTM. I'll land this. Thanks for the patch!
7 years, 8 months ago (2013-04-12 08:10:09 UTC) #2
Michael Starzinger
Committed patchset #1 manually as r14242 (presubmit successful).
7 years, 8 months ago (2013-04-12 08:45:23 UTC) #3
Jens Widell
7 years, 8 months ago (2013-04-12 08:48:00 UTC) #4
Message was sent while issue was closed.
On 2013/04/12 08:45:23, Michael Starzinger wrote:
> Committed patchset #1 manually as r14242 (presubmit successful).

Many thanks!

Powered by Google App Engine
This is Rietveld 408576698