src/v8natives.js - Issue 13914003: Fix detection of indexed properties in Object.defineProperty()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 13914003: Fix detection of indexed properties in Object.defineProperty() (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

===================================================================

--- src/v8natives.js (revision 14222)

+++ src/v8natives.js (working copy)

@@ -950,7 +950,7 @@

// Step 4 - Special handling for array index.

var index = ToUint32(p);

- if (index == ToNumber(p) && index != 4294967295) {

+ if (ToString(index) == p && index != 4294967295) {

var length = obj.length;

var length_desc = GetOwnProperty(obj, "length");

if ((index >= length && !length_desc.isWritable()) ||

« no previous file with comments | « no previous file | test/mjsunit/object-define-property.js » ('j') | no next file with comments »