Chromium Code Reviews| Index: runtime/vm/cpu_arm.cc |
| diff --git a/runtime/vm/cpu_arm.cc b/runtime/vm/cpu_arm.cc |
| index 5a6695434c39d7bd5fe68d0c13d5716bc3256beb..3a6e769c739500a1f46d021a39f1b04b1fa8c4f0 100644 |
| --- a/runtime/vm/cpu_arm.cc |
| +++ b/runtime/vm/cpu_arm.cc |
| @@ -165,11 +165,16 @@ void HostCPUFeatures::InitOnce() { |
| FLAG_use_vfp; |
| // Has integer division. |
| + // Special cases: |
| + // - Qualcomm Krait CPUs (QCT APQ8064) in Nexus 4 and 7 incorrectly report |
| + // that they lack integer division. |
| + // - Marvell Armada 370/XP incorrectly reports that it has integer division. |
| bool is_krait = CpuInfo::FieldContains(kCpuInfoHardware, "QCT APQ8064"); |
| + bool is_armada_370xp = |
| + CpuInfo::FieldContains(kCpuInfoHardware, "Marvell Armada 370/XP"); |
| if (is_krait) { |
| - // Special case for Qualcomm Krait CPUs in Nexus 4 and 7. |
| integer_division_supported_ = FLAG_use_integer_division; |
| - } else { |
| + } else if (!is_armada_370xp) { |
|
regis
2015/10/07 17:12:20
It would be clearer to set the value (again) to fa
zra
2015/10/07 22:56:14
Done.
|
| integer_division_supported_ = |
| (CpuInfo::FieldContains(kCpuInfoFeatures, "idiva") || is_arm64) && |
| FLAG_use_integer_division; |