Adds a special case for Marvell Armada 370/XP ARM CPUs

runtime/vm/cpu_arm.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/cpuinfo.h"
@@ skipping 147 matching lines @@
            CpuInfo::FieldContains(kCpuInfoModel, "ARMv7"));
     arm_version_ = ARMv7;
   }
 
   // Has floating point unit.
   vfp_supported_ =
       (CpuInfo::FieldContains(kCpuInfoFeatures, "vfp") || is_arm64) &&
       FLAG_use_vfp;
 
   // Has integer division.
+  // Special cases:
+  // - Qualcomm Krait CPUs (QCT APQ8064) in Nexus 4 and 7 incorrectly report
+  //   that they lack integer division.
+  // - Marvell Armada 370/XP incorrectly reports that it has integer division.
   bool is_krait = CpuInfo::FieldContains(kCpuInfoHardware, "QCT APQ8064");
+  bool is_armada_370xp =
+      CpuInfo::FieldContains(kCpuInfoHardware, "Marvell Armada 370/XP");
   if (is_krait) {
-    // Special case for Qualcomm Krait CPUs in Nexus 4 and 7.
     integer_division_supported_ = FLAG_use_integer_division;
-  } else {
+  } else if (!is_armada_370xp) {

[regis, 2015/10/07 17:12:20]

It would be clearer to set the value (again) to false and not rely on the
initialization value:

  } else if (is_armada_370xp) {
    integer_division_supported_ = false;
  } else {
    ...

[zra, 2015/10/07 22:56:14]

Done.

     integer_division_supported_ =
         (CpuInfo::FieldContains(kCpuInfoFeatures, "idiva") || is_arm64) &&
         FLAG_use_integer_division;
   }
   neon_supported_ =
       (CpuInfo::FieldContains(kCpuInfoFeatures, "neon") || is_arm64) &&
       FLAG_use_vfp && FLAG_use_neon;
 
   // Use the cross-compiler's predefined macros to determine whether we should
   // use the hard or soft float ABI.
@@ skipping 50 matching lines @@
   ASSERT(hardware_ != NULL);
   free(const_cast<char*>(hardware_));
   hardware_ = NULL;
   CpuInfo::Cleanup();
 }
 #endif  // !defined(USING_SIMULATOR)
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM