Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1391313002: Adds a special case for Marvell Armada 370/XP ARM CPUs (Closed)

Created:
5 years, 2 months ago by zra
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds a special case for Marvell Armada 370/XP ARM CPUs It reports availability of integer division instructions, but these instructions trigger SIGILL faults. BUG=https://github.com/dart-lang/sdk/issues/24466 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/ccc7786362a17f3d80a22fe58ccd01e988f274bb

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M runtime/vm/cpu_arm.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
5 years, 2 months ago (2015-10-07 16:38:42 UTC) #2
regis
lgtm https://codereview.chromium.org/1391313002/diff/1/runtime/vm/cpu_arm.cc File runtime/vm/cpu_arm.cc (right): https://codereview.chromium.org/1391313002/diff/1/runtime/vm/cpu_arm.cc#newcode177 runtime/vm/cpu_arm.cc:177: } else if (!is_armada_370xp) { It would be ...
5 years, 2 months ago (2015-10-07 17:12:20 UTC) #3
zra
Thanks! https://codereview.chromium.org/1391313002/diff/1/runtime/vm/cpu_arm.cc File runtime/vm/cpu_arm.cc (right): https://codereview.chromium.org/1391313002/diff/1/runtime/vm/cpu_arm.cc#newcode177 runtime/vm/cpu_arm.cc:177: } else if (!is_armada_370xp) { On 2015/10/07 17:12:20, ...
5 years, 2 months ago (2015-10-07 22:56:14 UTC) #4
zra
5 years, 2 months ago (2015-10-07 22:56:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ccc7786362a17f3d80a22fe58ccd01e988f274bb.

Powered by Google App Engine
This is Rietveld 408576698