third_party/WebKit/Source/web/WebFrameWidgetImpl.h - Issue 1391073002: [Oilpan] Fix wrong usage off heap collections in WebDevToolsAgentImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 1391073002: [Oilpan] Fix wrong usage off heap collections in WebDevToolsAgentImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('K') | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h

index dfebc2a2422bfef2fb82af9500ff21cc068e0425..09f26fca2ec701d5d271d2fc40e4383a962043a2 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h

@@ -63,7 +63,7 @@ class WebFrameWidgetImpl final : public RefCountedWillBeGarbageCollectedFinalize

, public PageWidgetEventHandler {

public:

static WebFrameWidgetImpl* create(WebWidgetClient*, WebLocalFrame*);

- static HashSet<WebFrameWidgetImpl*>& allInstances();

+ static WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<WebFrameWidgetImpl>>& allInstances();

// WebWidget functions:

void close() override;