Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391073002: [Oilpan] Fix wrong usage off heap collections in WebDevToolsAgentImpl (Closed)

Created:
5 years, 2 months ago by peria
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong usage of Vector<WebFrameWidgetImpl> and HashSet<WebFrameWidgetImpl> in WebDevToolsAgentImpl BUG=515524 Committed: https://crrev.com/9f4c1df8db418580510a6cf16930d2513336a287 Cr-Commit-Position: refs/heads/master@{#354236}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Make alias to simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
peria
PTL
5 years, 2 months ago (2015-10-14 06:41:59 UTC) #3
haraken
LGTM https://codereview.chromium.org/1391073002/diff/20001/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1391073002/diff/20001/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp#newcode229 third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:229: typedef WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<WebFrameWidgetImpl>> FrozenWidgetsSet; Can we move the typedef ...
5 years, 2 months ago (2015-10-14 08:12:13 UTC) #4
peria
https://codereview.chromium.org/1391073002/diff/20001/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1391073002/diff/20001/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp#newcode229 third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:229: typedef WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<WebFrameWidgetImpl>> FrozenWidgetsSet; On 2015/10/14 08:12:13, haraken wrote: > ...
5 years, 2 months ago (2015-10-15 02:26:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391073002/40001
5 years, 2 months ago (2015-10-15 05:13:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-15 07:33:04 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 07:33:52 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9f4c1df8db418580510a6cf16930d2513336a287
Cr-Commit-Position: refs/heads/master@{#354236}

Powered by Google App Engine
This is Rietveld 408576698