Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: Source/core/rendering/RenderLayerCompositor.cpp

Issue 139103009: If a compositing update is declared as needed, scheduleAnimation should be triggered. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: patch for landing, added crbug to fixme comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderImage.cpp ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/RenderLayerCompositor.cpp b/Source/core/rendering/RenderLayerCompositor.cpp
index 1b8d51ed94b5ba2d93e2f6ad083ed0b1dd0fef50..15ecec827bcb3cf4bf5883b1ffbe45b3b7db19c2 100644
--- a/Source/core/rendering/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/RenderLayerCompositor.cpp
@@ -296,8 +296,11 @@ bool RenderLayerCompositor::canRender3DTransforms() const
void RenderLayerCompositor::setCompositingLayersNeedRebuild(bool needRebuild)
{
+ // FIXME: crbug,com/332248 ideally this could be merged with setNeedsCompositingUpdate().
if (inCompositingMode())
m_compositingLayersNeedRebuild = needRebuild;
+
+ m_renderView->frameView()->scheduleAnimation();
}
void RenderLayerCompositor::updateCompositingRequirementsState()
@@ -385,10 +388,7 @@ void RenderLayerCompositor::setNeedsCompositingUpdate(CompositingUpdateType upda
break;
}
- // FIXME: some senior devs are suggesting that we need to always schedule a frame here.
- // but we do seem to reach this point in code when frames are unnecessary and
- // we need to resolve those instances before initiating a frame here, otherwise
- // performance will regress by forcing unnecessary frames.
+ m_renderView->frameView()->scheduleAnimation();
}
void RenderLayerCompositor::updateCompositingLayers()
« no previous file with comments | « Source/core/rendering/RenderImage.cpp ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698