Source/core/rendering/RenderImage.cpp - Issue 139103009: If a compositing update is declared as needed, scheduleAnimation should be triggered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderImage.cpp

Issue 139103009: If a compositing update is declared as needed, scheduleAnimation should be triggered. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: patch for landing, added crbug to fixme comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderImage.cpp

diff --git a/Source/core/rendering/RenderImage.cpp b/Source/core/rendering/RenderImage.cpp

index e2277ee0b80094c5af5aa759fab2b48b07a5641e..fa0845843cf4c96b1917d1099e05c7ca221fd10a 100644

--- a/Source/core/rendering/RenderImage.cpp

+++ b/Source/core/rendering/RenderImage.cpp

@@ -160,10 +160,6 @@ void RenderImage::imageChanged(WrappedImagePtr newImage, const IntRect* rect)

if (newImage != m_imageResource->imagePtr())

return;

- // FIXME: this is a quick fix for crbug.com/328069. Perhaps this is reasonable to keep for the long term, or

- // perhaps it's too aggressive, and we need to identify when the image *really* changed before issuing this call?

- document().view()->scheduleAnimation();

// Per the spec, we let the server-sent header override srcset/other sources of dpr.

// https://github.com/igrigorik/http-client-hints/blob/master/draft-grigorik-http-client-hints-01.txt#L255

if (m_imageResource->cachedImage() && m_imageResource->cachedImage()->hasDevicePixelRatioHeaderValue())

« no previous file with comments | « Source/core/page/ChromeClient.h ('k') | Source/core/rendering/RenderLayerCompositor.cpp » ('j') | no next file with comments »