Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139103003: Reland "Remove children from HistoryNodes that redirect during back/forward navigation" (Closed)

Created:
6 years, 11 months ago by Nate Chapin
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Reland "Remove children from HistoryNodes that redirect during back/forward navigation" This reverts commit 4595779d7010edec31a2224acd2a3a71a2ad206e. BUG=334598 TEST=http/tests/navigation/back-to-redirect-with-frame.html R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165535

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : More contained solution #

Patch Set 4 : Make trybots happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
A LayoutTests/http/tests/navigation/back-to-redirect-with-frame.php View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/back-to-redirect-with-frame-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/HistoryController.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/HistoryController.cpp View 1 2 3 2 chunks +28 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nate Chapin
It looks like the original version caused crashes because it removed HistoryNodes from the tree, ...
6 years, 11 months ago (2014-01-21 22:08:15 UTC) #1
abarth-chromium
LGTM ok..
6 years, 11 months ago (2014-01-21 23:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/139103003/100001
6 years, 11 months ago (2014-01-21 23:01:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/139103003/170002
6 years, 11 months ago (2014-01-21 23:25:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18445
6 years, 11 months ago (2014-01-22 01:12:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/139103003/170002
6 years, 11 months ago (2014-01-22 02:49:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18523
6 years, 11 months ago (2014-01-22 05:48:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/139103003/170002
6 years, 11 months ago (2014-01-22 06:13:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8543
6 years, 11 months ago (2014-01-22 10:32:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/139103003/170002
6 years, 11 months ago (2014-01-22 17:04:04 UTC) #10
Nate Chapin
6 years, 11 months ago (2014-01-22 17:11:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 manually as r165535 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698