Source/core/page/HistoryController.h - Issue 139103003: Reland "Remove children from HistoryNodes that redirect during back/forward navigation"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/HistoryController.h

Issue 139103003: Reland "Remove children from HistoryNodes that redirect during back/forward navigation" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make trybots happy Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/navigation/back-to-redirect-with-frame-expected.txt ('k') | Source/core/page/HistoryController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/HistoryController.h

diff --git a/Source/core/page/HistoryController.h b/Source/core/page/HistoryController.h

index acb1026a30a134a2ecd62d543399453935f7fb74..fc8188381d59dad8363d81c6d485f8cdcb417b6c 100644

--- a/Source/core/page/HistoryController.h

+++ b/Source/core/page/HistoryController.h

@@ -101,6 +101,7 @@ public:

HistoryItem* value() { return m_value.get(); }

void updateValue(PassRefPtr<HistoryItem> item) { m_value = item; }

const Vector<OwnPtr<HistoryNode> >& children() const { return m_children; }

+ void removeChildren();

private:

HistoryNode(HistoryEntry*, HistoryItem*);

@@ -108,6 +109,7 @@ private:

HistoryEntry* m_entry;

Vector<OwnPtr<HistoryNode> > m_children;

RefPtr<HistoryItem> m_value;

};

class HistoryEntry {

@@ -147,6 +149,7 @@ public:

PassRefPtr<HistoryItem> currentItemForExport();

PassRefPtr<HistoryItem> previousItemForExport();

HistoryItem* itemForNewChildFrame(Frame*) const;

+ void removeChildrenForRedirect(Frame*);

void setDefersLoading(bool);