Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1391023006: Fix for cdb tests (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix for cdb tests There's a problem running crashpad_handler, but I'm not sure what it is. I think an exception is getting swallowed because my handling of `handler` was incorrect, so correctly initialize that to see the exception. https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x64_rel/builds/36/steps/run%20tests/logs/stdio """ UnboundLocalError: local variable 'handler' referenced before assignment """ (I also realized the !locks code hasn't landed yet so disable those tests for now too.) R=mark@chromium.org BUG=crashpad:46 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/52238122e99c23af3ee7fc3186ca0dd0e79a4532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M snapshot/win/end_to_end_test.py View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 2 months ago (2015-10-09 20:56:10 UTC) #1
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-09 20:57:08 UTC) #2
scottmg
5 years, 2 months ago (2015-10-09 20:59:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52238122e99c23af3ee7fc3186ca0dd0e79a4532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698