Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1391023006: Fix for cdb tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/end_to_end_test.py
diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py
index 64de3b21078edcf07735d22fd0fccf8f6887c679..6b55884aba440c6ad3efdc134f2c84041b9a0170 100644
--- a/snapshot/win/end_to_end_test.py
+++ b/snapshot/win/end_to_end_test.py
@@ -81,6 +81,7 @@ def GetDumpFromCrashyProgram(out_dir, pipe_name):
crash_handler for further testing.
"""
test_database = MakeTempDir()
+ handler = None
try:
if subprocess.call(
@@ -106,7 +107,6 @@ def GetDumpFromCrashyProgram(out_dir, pipe_name):
for line in out.splitlines():
if line.strip().startswith('Path:'):
return line.partition(':')[2].strip()
-
finally:
if handler:
handler.kill()
@@ -177,10 +177,11 @@ def RunTests(cdb_path, dump_path, pipe_name):
'file %hs does not exist.', '!gle gets last ntstatus')
# Locks.
- out = CdbRun(cdb_path, dump_path, '!locks')
- out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
- r'g_test_critical_section', 'lock was captured')
- out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
+ if False: # The code for these isn't landed yet.
+ out = CdbRun(cdb_path, dump_path, '!locks')
+ out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
+ r'g_test_critical_section', 'lock was captured')
+ out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
def main(args):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698