Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1390923003: [Oilpan] Fix wrong usage of Vector<WilBeGCMixin*> in LifecycleNotifier (Closed)

Created:
5 years, 2 months ago by peria
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong usage of Vector<WilBeGCMixin*> in LifecycleNotifier BUG=515524 Committed: https://crrev.com/0bc2d5b5dcb477d938ac3e954a067b62b733bbf7 Cr-Commit-Position: refs/heads/master@{#352776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/LifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
peria
PTL
5 years, 2 months ago (2015-10-07 01:54:57 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-07 01:55:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390923003/1
5 years, 2 months ago (2015-10-07 01:59:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/128649) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-07 02:21:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390923003/1
5 years, 2 months ago (2015-10-07 02:52:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/113915)
5 years, 2 months ago (2015-10-07 04:07:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390923003/1
5 years, 2 months ago (2015-10-07 04:10:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 05:34:31 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 05:35:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bc2d5b5dcb477d938ac3e954a067b62b733bbf7
Cr-Commit-Position: refs/heads/master@{#352776}

Powered by Google App Engine
This is Rietveld 408576698